[asterisk-dev] [Code Review] 3466: HTTP: Add TCP_NODELAY to accepted connections

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3466/#review11687
-----------------------------------------------------------



branches/1.8/main/http.c
<https://reviewboard.asterisk.org/r/3466/#comment21454>

    s/peices/pieces/



branches/1.8/main/http.c
<https://reviewboard.asterisk.org/r/3466/#comment21456>

    I recommend a different set of warning messages here, just so someone trying to debug can more accurately determine what is going wrong.


- Mark Michelson


On April 18, 2014, 3:42 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3466/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 3:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the TCP_NODELAY option to accepted connections on the HTTP server built into Asterisk. This option disables the Nagle algorithm which controls queueing of outbound data and in some cases can cause delays on receipt of response by the client due to how the Nagle algorithm interacts with TCP delayed ACK. This option is already set on all non-HTTP AMI connections and this change would cover standard HTTP requests, manager HTTP connections, and ARI HTTP requests and websockets in Asterisk 12+ along with any future use of the HTTP server.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/http.c 412564 
> 
> Diff: https://reviewboard.asterisk.org/r/3466/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/bb19ca2b/attachment-0001.html>