[asterisk-dev] [Code Review] 3466: HTTP: Add TCP_NODELAY to accepted connections

[opticron]

> On April 18, 2014, 9:52 a.m., Joshua Colp wrote:
> > branches/1.8/main/http.c, line 895
> > <https://reviewboard.asterisk.org/r/3466/diff/2/?file=57633#file57633line895>
> >
> >     The other use of this uses "tcp" - is there any difference between that and tls? Do we need to choose one or the other based on the connection?

That should read "tcp" since that is the underlying protocol. Bad diff.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3466/#review11685
-----------------------------------------------------------


On April 18, 2014, 9:41 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3466/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 9:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the TCP_NODELAY option to accepted connections on the HTTP server built into Asterisk. This option disables the Nagle algorithm which controls queueing of outbound data and in some cases can cause delays on receipt of response by the client due to how the Nagle algorithm interacts with TCP delayed ACK. This option is already set on all non-HTTP AMI connections and this change would cover standard HTTP requests, manager HTTP connections, and ARI HTTP requests and websockets in Asterisk 12+ along with any future use of the HTTP server.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/http.c 412564 
> 
> Diff: https://reviewboard.asterisk.org/r/3466/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/6721aac1/attachment.html>