[asterisk-dev] [Code Review] 3464: Sounds: Various new sound sets were missing from the makefile and menuselect options

[Michael Young]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3464/#review11683
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Young


On April 17, 2014, 7:18 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3464/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 7:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23550
>     https://issues.asterisk.org/jira/browse/ASTERISK-23550
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Apparently back when we added the IT,en_GB,en_AU sound sets, we didn't get the menuselect stuff modified for it all. (I'm pretty sure I just didn't realize what I had to modify)
> 
> Along the way I fixed some other minor problems.
> 
> The main diff does the following:
> 
> In sounds/Makefile
> 
>  1 Adds and moves some lines necessary for the en_GB core set. I'm just following how the other sets are defined here.
>  2 removes the ES extra sounds related lines as we don't have ES extra sound sets. 
> 
> In sounds/sounds.xml
> 
>  3 Adds <support_level> definitions to all the sound sets as we have these defined in 11,12,Trunk, but not in 1.8
>  4 Adds member definitons for EN_AU, EN_GB, IT for core sound sets, and EN_GB in extra sound sets
> 
> The attached 11plus.patch is the same patch, but without item #3 above, as that is fine in 11,12,Trunk.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/sounds/sounds.xml 412484 
>   /branches/1.8/sounds/Makefile 412484 
> 
> Diff: https://reviewboard.asterisk.org/r/3464/diff/
> 
> 
> Testing
> -------
> 
> In 1.8 and 12, configured in dev mode, built, installed, verified sound packages selected in menuselect get pulled down and extracted to their various directories. Tested with a random selection of formats from each language set of en_AU,en_GB, IT.
> 
> 
> File Attachments
> ----------------
> 
> Patch for 11,12,Trunk
>   https://reviewboard.asterisk.org/media/uploaded/files/2014/04/17/4421ac84-bf9f-417d-9449-a582ee90430d__asterisk23550_11plus.patch
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/2d047763/attachment.html>