[asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

[Pavel Troller]

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3447/#review11635
> -----------------------------------------------------------
> 
> 
> Hey wdoekes, I'm trying to figure out a similar chart for sendrpid=rpid
> 
>                       | pres=allowed                                                                         | pres=prohibited                                                                         |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> trust_id_outbound=no  | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at anonymous.invalid>party=calling;privacy=full;screen=yes |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> trust_id_outbound=yes | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=full;screen=yes  |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> 
> Does that look about like what you would expect? This is keeping in mind that the trust_id_outbound=no row mirrors the current expectations.
> 
> - Jonathan Rose
> 
Hi!
  PLEASE, don't touch the screening indicator (screen=xxx). It has NOTHING to do with presentation of the number. It should be setup by the dialplan to reflect, whether the number is verified by the exchange and it's valid (i.e. belongs to a person , who sent it) or not. When the number comes from the trunk (again, it's on the dialplan logic to recognize, that the connection is categorized as a trunk), it should be kept intact, i.e. the value coming from the trunk must be preserved for the outgoing connection. Forcing the screening indicator direclty from the chan_sip without any preceding knowledge is really a BAD_THING.
  With regards,
    Pavel