[asterisk-dev] [Code Review] 3439: chan_sip: Support a=rtcp attribute in SDP

[Olle E Johansson]

> On April 16, 2014, 2:13 a.m., Corey Farrell wrote:
> > /trunk/channels/chan_sip.c, line 11195
> > <https://reviewboard.asterisk.org/r/3439/diff/1/?file=57242#file57242line11195>
> >
> >     I will not get in the way if this change does not support parsing the optional address of the rtcp attribute.
> >     
> >     For any rtcp attribute where the address is specified, we need to either parse it or reject the whole attribute and return FALSE.

Good idea, but if you want to change to "rctp:" we will have to change all other parts of the code that parses sdp, and that's another patch than his. I will follow the rest of the code in this small patch.

I'll check on the address part. I've never seen it around.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3439/#review11624
-----------------------------------------------------------


On April 11, 2014, 3:46 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3439/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> the A=rtcp attribute in SDP points out a different port than the mediaport+1 to receive RTCP on. This patch adds a new api to rtpengine and res_rtp_asterisk and updates chan_sip to use it.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_rtp_asterisk.c 412166 
>   /trunk/main/rtp_engine.c 412166 
>   /trunk/include/asterisk/rtp_engine.h 412166 
>   /trunk/channels/chan_sip.c 412166 
> 
> Diff: https://reviewboard.asterisk.org/r/3439/diff/
> 
> 
> Testing
> -------
> 
> A massive amount of testing with a test tool for interoperability.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140416/be3d28d0/attachment.html>