[asterisk-dev] [Code Review] 3448: res_pjsip: Handle reloading when permanent contacts exist and qualify is configured

Joshua Colp reviewboard at asterisk.org
Tue Apr 15 12:31:09 CDT 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.

Bugs: ASTERISK-23514

Repository: Asterisk


This change fixes a problem where permanent contacts being qualified were not being updated. This was caused by the permanent contacts getting a uuid and not a known identifier, causing an inability to look them up when updating in the qualify code. A bug also existed where the new configuration may not be available immediately when updating qualifies. The attached change (mostly done by Richard) fixes these:

1. Made permanent contacts have a predictable sorcery id instead of a UUID so updates can replace previous scheduled contacts. The aor permanent contacts container is sorted to reject duplicate contact URI's.

2. Changed the sched_qualifies container to be searchable so a scheduled qualify poll can be directly found instead of traversing the container to find it.

3. Changed reloading so all reload operations happen within the same task.


  /branches/12/res/res_pjsip_registrar.c 412327 
  /branches/12/res/res_pjsip/pjsip_options.c 412327 
  /branches/12/res/res_pjsip/pjsip_configuration.c 412327 
  /branches/12/res/res_pjsip/location.c 412327 
  /branches/12/res/res_pjsip.c 412327 

Diff: https://reviewboard.asterisk.org/r/3448/diff/


Reloaded multiple times changing configuration and confirmed that changes were reflected.


Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140415/db8e9889/attachment.html>

More information about the asterisk-dev mailing list