[asterisk-dev] [Code Review] 3419: Test for PJSIP fast picture update

[opticron]

> On April 10, 2014, 9:56 a.m., opticron wrote:
> > ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/start-call.xml, line 58
> > <https://reviewboard.asterisk.org/r/3419/diff/1/?file=57067#file57067line58>
> >
> >     This needs to send a response 200 OK back and should also check the contents of the INFO request.
> 
> Benjamin Keith Ford wrote:
>     I understand why the 200 OK should be sent, but as for the INFO request, I'm curious why it needs to check the contents since this test is just to see if a picture update event shows up or not. Is it just for a confirmation of what kind of packet it is receiving?

That is correct. INFO requests are used for more than just fast picture updates.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3419/#review11549
-----------------------------------------------------------


On April 4, 2014, 4:12 p.m., Benjamin Keith Ford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3419/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 4:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23562
>     https://issues.asterisk.org/jira/browse/ASTERISK-23562
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test verifies that when two PJSIP endpoints are in a call with video enabled, fast picture updates can be received when one endpoint requests INFO. The following code was added as well to create a TestEvent that spawns when the INFO is created:
> 
> Index: channels/chan_pjsip.c
> ===================================================================
> --- channels/chan_pjsip.c	(revision 408267)
> +++ channels/chan_pjsip.c	(working copy)
> @@ -57,6 +57,7 @@
>  #include "asterisk/stasis_endpoints.h"
>  #include "asterisk/stasis_channels.h"
>  #include "asterisk/indications.h"
> +#include "asterisk/manager.h"
>  
>  #include "asterisk/res_pjsip.h"
>  #include "asterisk/res_pjsip_session.h"
> @@ -1112,8 +1113,14 @@
>  					ao2_cleanup(channel->session);
>  				}
>  			}
> +                        manager_event(EVENT_FLAG_TEST, "TestEvent",
> +                                        "Type: AST_CONTROL_VIDUPDATE\r\n"
> +                                        "Result: Success");
>  		} else {
>  			res = -1;
> +                        manager_event(EVENT_FLAG_TEST, "TestEvent",
> +                                        "Type: AST_CONTROL_VIDUPDATE\r\n"
> +                                        "Result: Failure");
>  		}
>  		break;
>  	case AST_CONTROL_CONNECTED_LINE:
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/start-call.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/receive-call.xml PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/channels/pjsip/tests.yaml 4918 
> 
> Diff: https://reviewboard.asterisk.org/r/3419/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Keith Ford
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140410/05f66175/attachment-0001.html>