[asterisk-dev] [Code Review] 3422: testsuite: Fix Asterisk shutdown timeout in chan_sip session_timer tests by hanging up channels

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3422/#review11560
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On April 5, 2014, 7:38 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3422/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 7:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23591
>     https://issues.asterisk.org/jira/browse/ASTERISK-23591
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> 11 of the chan_sip session_timer tests fail to hangup channels from sipp.  This causes graceful shutdown to timeout, and asterisk is killed.
> 
> Fixing this reduces overall test time by 2 minutes, more if the asterisk shutdown timeout is increased.
> 
> Before anyone asks: yes, the added XML is identical on every single test.  Most of the files were already identical except a line or two, the goal of this change is to fix the timeout's.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_no_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_medium_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_large_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_no_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_medium_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_large_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_no_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_medium_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_large_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_no_se/sipp/uac-session-timer.xml 4894 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_large_se/sipp/uac-session-timer.xml 4894 
> 
> Diff: https://reviewboard.asterisk.org/r/3422/diff/
> 
> 
> Testing
> -------
> 
> Testing was done with patch from ASTERISK-23369 so that asterisk shutdown timeout caused failures.
> 
> Retested with this patch, no failures in tests/channels/SIP/session_timers.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140410/21d3d0b4/attachment.html>