[asterisk-dev] [Code Review] 2684: Fix exposure of template-only config sections

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2684/
-----------------------------------------------------------

(Updated April 8, 2014, 8:04 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

While working on a deployment, I had to change the [directories] section of asterisk.conf from the defaults.  That worked.  Later I noticed that the directories section was defined as a template-only section like so:

    [directories](!)

which means my changes should *not* have taken effect.  This one line change fixes that.

As a side note, while looking at this, I noticed multiple cases of comparing against a category name like this throughout the file, which seems wrong:

from ast_category_delete()

                if (cat->name == category) {

from ast_variable_browse()

        if (config->last_browse && (config->last_browse->name == category)) {

etc.


Diffs
-----

  /trunk/main/config.c 394685 

Diff: https://reviewboard.asterisk.org/r/2684/diff/


Testing
-------


Thanks,

Russell Bryant

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140409/69d66afe/attachment.html>