[asterisk-dev] [Code Review] 3424: mixmonitor: Add option to enable a periodic beep

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3424/#review11515
-----------------------------------------------------------


Does this module need to be tagged with optional dependency func_periodic_hook?


/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/3424/#comment21242>

    Maybe say that the default interval 15 is being used?  This warning isn't clear about the fact that we are still enabling beep and recording.



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/3424/#comment21245>

    Error checking.  As with situations where func_periodic_hook is not loaded I think failure here should abort the recording.



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/3424/#comment21243>

    I think this should be an error, and we should abort recording.  The main reason to use this flag will be for policy compliance reasons.  In that case it might be unacceptable or illegal to continue recording without beeps.



/trunk/main/app.c
<https://reviewboard.asterisk.org/r/3424/#comment21241>

    Can we create the context from func_periodic_hook?  My complaint is that for anyone not using func_periodic_hook this context is just wasted memory.
    
    Another way to deal with this would be for ast_app_get_beep_* to call init_beep_helper and track if we've created the extensions or not.
    
    In any case please ensure the internal dialplan is removed at shutdown.


- Corey Farrell


On April 7, 2014, 9:28 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3424/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 9:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add an option to enable a periodic beep to be played into a call if it
> is being recorded.  If enabled, it uses the PERIODIC_HOOK() function
> internally to play the 'beep' prompt into the call at a specified
> interval.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/app.c 411908 
>   /trunk/include/asterisk/app.h 411908 
>   /trunk/apps/app_mixmonitor.c 411908 
> 
> Diff: https://reviewboard.asterisk.org/r/3424/diff/
> 
> 
> Testing
> -------
> 
> exten => 103,1,Answer()
>     same => n,MixMonitor(test.gsm,B(5))
>     same => n,MusicOnHold()
> 
> exten => 104,1,Answer()
>     same => n,MixMonitor(test.gsm,B)
>     same => n,MusicOnHold()
> 
> exten => 105,1,Answer()
>     same => n,MixMonitor(test.gsm,B(3))
>     same => n,StartMusicOnHold()
>     same => n,Wait(15)
>     same => n,StopMusicOnHold()
>     same => n,StopMixMonitor()
>     same => n,Wait(5)
>     same => n,Hangup()
> 
> 
> Thanks,
> 
> Russell Bryant
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140408/82b50d59/attachment.html>