[asterisk-dev] [Code Review] 3415: bridging: Ensure proper locking during snapshot creation

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3415/
-----------------------------------------------------------

(Updated April 4, 2014, 9:31 a.m.)


Review request for Asterisk Developers.


Changes
-------

Update preconditions for functions which generate bridge snapshots.


Bugs: ASTERISK-22904
    https://issues.asterisk.org/jira/browse/ASTERISK-22904


Repository: Asterisk


Description
-------

While the vast majority of bridge snapshot creation is locked properly, there are currently some instances that are not. This adds the missing locking to ensure bridge state is not malleable during snapshot creation.


Diffs (updated)
-----

  branches/12/tests/test_cel.c 411668 
  branches/12/res/ari/resource_bridges.c 411668 
  branches/12/main/bridge_basic.c 411668 
  branches/12/main/bridge.c 411668 
  branches/12/include/asterisk/stasis_bridges.h 411668 
  branches/12/apps/app_confbridge.c 411668 

Diff: https://reviewboard.asterisk.org/r/3415/diff/


Testing
-------

Ran the testsuite to ensure that it did not cause failures.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140404/4cebb4f1/attachment.html>