[asterisk-dev] [Code Review] 3412: testsuite: Add call setup tracking to masquerade supertest.

rmudgett reviewboard at asterisk.org
Thu Apr 3 15:45:40 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3412/
-----------------------------------------------------------

(Updated April 3, 2014, 3:45 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed PEP8 mmichelson pointed out.  Other PEP8 changes should wait for a separate patch unless they directly affect the changed lines in this patch.


Bugs: ASTERISK-22846
    https://issues.asterisk.org/jira/browse/ASTERISK-22846


Repository: testsuite


Description
-------

* Changed originated calls to use AMI originate instead of CLI originate so a custom call timeout could be specified.  The number of calls in the chain could take awhile to setup which the CLI originate might timeout before all calls in the chain were dialed.

* Call setup is now tracked to so the test can better distinguish when calls hangup if they were optimizations or timeout hangups.

* Added some helpful test failure diagnosis messages when the reactor is stopped.

* Added needed debug routines to get "core show locks" output into the test log.

NOTE:  This is an older test that was written before PEP8 was more rigidly enforced in review.  Another patch will be made to clear up PEP8 formatting compliance.


Diffs (updated)
-----

  /asterisk/trunk/tests/masquerade/run-test 4929 
  /asterisk/trunk/tests/masquerade/configs/ast1/extensions.conf 4929 

Diff: https://reviewboard.asterisk.org/r/3412/diff/


Testing
-------

I've done many test runs looking for why the masquerade test fails and I have seen just about all the failure cases reported.

The core show locks code works when I uncomment and comment the right lines.  It showed that the problem was not a deadlock on Asterisk v12.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140403/c35547ec/attachment.html>


More information about the asterisk-dev mailing list