[asterisk-dev] [Code Review] 3413: media_formats: move app.c and file.c over

Mark Michelson reviewboard at asterisk.org
Thu Apr 3 13:35:30 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3413/#review11483
-----------------------------------------------------------

Ship it!



team/kharwell/media_formats_app_file/main/file.c
<https://reviewboard.asterisk.org/r/3413/#comment21207>

    Since you're poking in this area, I suggest placing curly braces on these if statements.


- Mark Michelson


On April 2, 2014, 10:02 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3413/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 10:02 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves app.c and file.c over to the media formats API.
> 
> 
> Diffs
> -----
> 
>   team/kharwell/media_formats_app_file/main/file.c 411583 
>   team/kharwell/media_formats_app_file/main/app.c 411583 
>   team/kharwell/media_formats_app_file/include/asterisk/format.h 411583 
> 
> Diff: https://reviewboard.asterisk.org/r/3413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140403/79e9c524/attachment.html>


More information about the asterisk-dev mailing list