[asterisk-dev] [Code Review] 3412: testsuite: Add call setup tracking to masquerade supertest.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3412/#review11482
-----------------------------------------------------------


I recommend running your changes through a PEP8 checker of some sort (such as pylint). I'll point out some of the violations I see, but a static checker will point out others.


/asterisk/trunk/tests/masquerade/run-test
<https://reviewboard.asterisk.org/r/3412/#comment21205>

    When using named parameters in calls, don't put spaces around the = sign:
    
    Good: obj.foo(param="eggs")
    Bad: obj.foo(param = "eggs")
    
    This applies to all of the originations you've modified in this file.



/asterisk/trunk/tests/masquerade/run-test
<https://reviewboard.asterisk.org/r/3412/#comment21206>

    Just use
    
    logger.info(cli_command.output)


- Mark Michelson


On April 2, 2014, 12:09 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3412/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 12:09 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22846
>     https://issues.asterisk.org/jira/browse/ASTERISK-22846
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> * Changed originated calls to use AMI originate instead of CLI originate so a custom call timeout could be specified.  The number of calls in the chain could take awhile to setup which the CLI originate might timeout before all calls in the chain were dialed.
> 
> * Call setup is now tracked to so the test can better distinguish when calls hangup if they were optimizations or timeout hangups.
> 
> * Added some helpful test failure diagnosis messages when the reactor is stopped.
> 
> * Added needed debug routines to get "core show locks" output into the test log.
> 
> NOTE:  This is an older test that was written before PEP8 was more rigidly enforced in review.  Another patch will be made to clear up PEP8 formatting compliance.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/masquerade/run-test 4926 
>   /asterisk/trunk/tests/masquerade/configs/ast1/extensions.conf 4926 
> 
> Diff: https://reviewboard.asterisk.org/r/3412/diff/
> 
> 
> Testing
> -------
> 
> I've done many test runs looking for why the masquerade test fails and I have seen just about all the failure cases reported.
> 
> The core show locks code works when I uncomment and comment the right lines.  It showed that the problem was not a deadlock on Asterisk v12.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140403/a0175b9a/attachment-0001.html>