[asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

Corey Farrell reviewboard at asterisk.org
Tue Apr 1 15:44:06 CDT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated April 1, 2014, 3:44 p.m.)


This change has been marked as submitted.

Review request for Asterisk Developers.


Committed in revision 411633

Bugs: ASTERISK-23559

Repository: Asterisk


ASTERISK-23391 caused a regression in Asterisk 11. defaultlanguage is used as a fall-back when no channel is available. This variable is listed in options.h, allowing compile to succeed. This caused a run-time symbol failure because defaultlanguage is not listed in main/asterisk.exports.in.

This fix adds the variable to exports for Asterisk 11 only.  I'm not against renaming the variable to ast_defaultlanguage in 11 if that is preferred.  The function wasn't in Asterisk 1.8 so no change was made there, Asterisk 12 renames the variable to ast_defaultlanguage so it was not a problem in 12+.


  /branches/11/utils/extconf.c 411572 
  /branches/11/main/channel.c 411572 
  /branches/11/main/asterisk.c 411572 
  /branches/11/include/asterisk/options.h 411572 
  /branches/11/apps/app_voicemail.c 411572 

Diff: https://reviewboard.asterisk.org/r/3408/diff/


Verified this corrects the symbol failure.


Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140401/eb62e542/attachment.html>

More information about the asterisk-dev mailing list