[asterisk-dev] [Code Review] 2888: AMI/CDR/CEL: only subscribe when enabled

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2888/#review9854
-----------------------------------------------------------


There is one problem that should be addressed.

When CDRs or CELs are disabled, the unit tests fail, and take a long
time getting around to fail (timeouts waiting for messages).

Ideally, the unit tests would enable the subsystem for the test, and
re-disable it when done (if appropriate).

- David Lee


On Sept. 27, 2013, 1:40 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2888/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 1:40 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Subscribing to Stasis isn't free.
> 
> As such, this patch makes AMI, CDR, and CEL - the "big 3" - only subscribe when enabled. Toggling their availability via a .conf file will unsubscribe/subscribe as appropriate.
> 
> Not subscribing when not available buys a measurable amount of performance when running under load.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/cdr.c 399992 
>   /branches/12/main/cel.c 399992 
>   /branches/12/main/manager.c 399992 
> 
> Diff: https://reviewboard.asterisk.org/r/2888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130928/7fcff82a/attachment.html>