[asterisk-dev] [Code Review] 2881: Performance: Taskprocessor optimization; switch Stasis to use taskprocessors

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2881/
-----------------------------------------------------------

(Updated Sept. 27, 2013, 2:58 p.m.)


Review request for Asterisk Developers.


Changes
-------

Review feedback:
* Catch errors trying to sem_init() with a value greater than AST_SEM_VALUE_MAX
* Use the AST_SEM_VALUE_MAX macro instead of INT_MAX in ast_sem_post()


Repository: Asterisk


Description
-------

This patch optimizes taskprocessor to use a semaphore for signaling,
which the OS can do a better job at managing contention and waiting
that we can with a mutex and condition.

The taskprocessor execution was also slightly optimized to reduce the
number of locks taken.

The only observable difference in the taskprocessor implementation is
that when the final reference to the taskprocessor goes away, it will
execute all tasks to completion instead of discarding the unexecuted
tasks.

For systems where unnamed semaphores are not supported, a really
simple semaphore implementation is provided. (Which gives identical
performance as the original taskprocessor implementation).

The way we ended up implementing Stasis caused the threadpool to be a
burden instead of a boost to performance. This was switched to just
use taskprocessors directly for subscriptions.


Diffs (updated)
-----

  /team/dlee/performance/configs/stasis.conf.sample 399869 
  /team/dlee/performance/configure UNKNOWN 
  /team/dlee/performance/configure.ac 399869 
  /team/dlee/performance/include/asterisk/autoconfig.h.in 399869 
  /team/dlee/performance/include/asterisk/sem.h PRE-CREATION 
  /team/dlee/performance/include/asterisk/stasis.h 399869 
  /team/dlee/performance/include/asterisk/taskprocessor.h 399869 
  /team/dlee/performance/main/sem.c PRE-CREATION 
  /team/dlee/performance/main/stasis.c 399869 
  /team/dlee/performance/main/stasis_config.c 399869 
  /team/dlee/performance/main/taskprocessor.c 399869 

Diff: https://reviewboard.asterisk.org/r/2881/diff/


Testing
-------

Unit tests pass.

Same performance test as from https://reviewboard.asterisk.org/r/2873/


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/53d28199/attachment.html>