[asterisk-dev] [Code Review] 2888: AMI/CDR/CEL: only subscribe when enabled

Matt Jordan reviewboard at asterisk.org
Fri Sep 27 13:40:11 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2888/
-----------------------------------------------------------

(Updated Sept. 27, 2013, 6:40 p.m.)


Review request for Asterisk Developers, David Lee, Joshua Colp, and Mark Michelson.


Changes
-------

Addressed Mark's findings.


Repository: Asterisk


Description
-------

Subscribing to Stasis isn't free.

As such, this patch makes AMI, CDR, and CEL - the "big 3" - only subscribe when enabled. Toggling their availability via a .conf file will unsubscribe/subscribe as appropriate.

Not subscribing when not available buys a measurable amount of performance when running under load.


Diffs (updated)
-----

  /branches/12/main/cdr.c 399992 
  /branches/12/main/cel.c 399992 
  /branches/12/main/manager.c 399992 

Diff: https://reviewboard.asterisk.org/r/2888/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/220a6430/attachment.html>


More information about the asterisk-dev mailing list