[asterisk-dev] [Code Review] 2874: Allow Asterisk to retry after 403 on register

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2874/#review9834
-----------------------------------------------------------

Ship it!



/trunk/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2874/#comment19034>

    This can be reformatted as
    
    } else if (response->code == 403) {
        ...
    } else {
        ...
    }
    
    instead of 
    
    } else {
        if (response->code == 403) {
            ...
        } else {
            ...
        }
    }


- Mark Michelson


On Sept. 23, 2013, 7:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2874/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 7:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-17138
>     https://issues.asterisk.org/jira/browse/ASTERISK-17138
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds an option in chan_sip and chan_pjsip to allow them to continue attempting registration if a 403 is received. Normally, this would cause registration attempts to that endpoint to stop.
> 
> In the case of chan_sip, this global option simply allows registration to continue past a 403 as if it was a non-fatal reply to retry later.
> 
> For chan_pjsip, this is a per outbound registration option that takes an interval in seconds to wait after a 403 to try again.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 399644 
>   /trunk/configs/pjsip.conf.sample 399644 
>   /trunk/configs/sip.conf.sample 399644 
>   /trunk/res/res_pjsip_outbound_registration.c 399644 
> 
> Diff: https://reviewboard.asterisk.org/r/2874/diff/
> 
> 
> Testing
> -------
> 
> Tests are available in the following review:
> https://reviewboard.asterisk.org/r/2875/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/388dc6b7/attachment-0002.html>