[asterisk-dev] [Code Review] 2888: AMI/CDR/CEL: only subscribe when enabled

[Matt Jordan]

> On Sept. 26, 2013, 10:06 p.m., rmudgett wrote:
> > Turning off AMI causes app_queue() to get the following ERROR when a device state changes:
> > ERROR[]: stasis.c:790 stasis_log_bad_type_access: Use of queue_member_status_type() before init/after destruction

Let's work that problem off of ASTERISK-22604 - while this exposes it, app_queue really shouldn't be dependent on AMI like it is either way.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2888/#review9814
-----------------------------------------------------------


On Sept. 26, 2013, 8:18 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2888/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 8:18 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Subscribing to Stasis isn't free.
> 
> As such, this patch makes AMI, CDR, and CEL - the "big 3" - only subscribe when enabled. Toggling their availability via a .conf file will unsubscribe/subscribe as appropriate.
> 
> Not subscribing when not available buys a measurable amount of performance when running under load.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/cel.c 399908 
>   /branches/12/main/cdr.c 399908 
>   /branches/12/main/manager.c 399908 
> 
> Diff: https://reviewboard.asterisk.org/r/2888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/12594fef/attachment-0002.html>