[asterisk-dev] [Code Review] 2867: Convert and update the local channel t38 queryoption test

Matt Jordan reviewboard at asterisk.org
Thu Sep 26 12:57:45 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2867/#review9798
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Sept. 25, 2013, 8:38 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2867/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 8:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22318
>     https://issues.asterisk.org/jira/browse/ASTERISK-22318
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This converts the local channel t38 queryoption test from lua to python and gets it working again on 11, 12, and trunk. The cause of the failures was not in the test itself and is addressed in https://reviewboard.asterisk.org/r/2866/.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/test.lua 4206 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test 4206 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2867/diff/
> 
> 
> Testing
> -------
> 
> Ran against 1.8, 11, 12, and trunk and verified expected behaviors.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130926/9ac54af5/attachment-0001.html>


More information about the asterisk-dev mailing list