[asterisk-dev] [Code Review] 2864: Testsuite: Fix sip_attended_transfer test for Asterisk 12+

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2864/#review9745
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Sept. 17, 2013, 5:40 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2864/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 5:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22531
>     https://issues.asterisk.org/jira/browse/ASTERISK-22531
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> sip_attended_transfer test was failing in Asterisk 12 because it was listening for nonexistent AMI events. Now it uses BridgeEnter and AttendedTransfer events in order to determine if the test was successful.
> 
> PEP-8: The new code should be PEP-8 compliant. I did not change pre-existing code though. The only change to pre-existing code I made was to add docstrings to some event callbacks since it was not immediately clear what they were doing.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/sip_attended_transfer/configs/ast1/sip.conf 4126 
>   /asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test 4126 
> 
> Diff: https://reviewboard.asterisk.org/r/2864/diff/
> 
> 
> Testing
> -------
> 
> Ran test multiple times against both Asterisk 11 and Asterisk 12. Test passes for me.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130920/0f3d93e9/attachment.htm>