[asterisk-dev] [Code Review] 2868: call forwarding: When forwarding calls from originate, Asterisk would crash.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2868/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 5:18 p.m.)


Review request for Asterisk Developers, Joshua Colp and Matt Jordan.


Changes
-------

Address Matt's feedback


Bugs: ASTERISK-22487
    https://issues.asterisk.org/jira/browse/ASTERISK-22487


Repository: Asterisk


Description
-------

When forwarding a call (basically a blind transfer when ringing) that has been originated, Asterisk would crash because a the original channel would be hung up twice. Also the context of the forwarding channel wouldn't be respected. This patch brings things more in line with how forwarding is handled in basic calls.


Diffs (updated)
-----

  /branches/12/main/dial.c 399197 

Diff: https://reviewboard.asterisk.org/r/2868/diff/


Testing
-------

Originated a call to SIP/A which would send the call into a holding bridge
While SIP/A was ringing, it requests forwarding to SIP/B
SIP/B picks up.

Prior to changes:
SIP/B wouldn't ring
Asterisk would crash due to hanging up a channel without a technology (since the first hangup strips the technology)

After the change:
SIP/B rings, picking up the call causes SIP/B to enter the holding bridge as expected (once local channels optimize out anyway).
Asterisk no longer crashes.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130919/2bd9f51c/attachment.htm>