[asterisk-dev] [Code Review] 2866: Ensure global types in the config framework are initialized

[opticron]

> On Sept. 18, 2013, 9:20 a.m., Mark Michelson wrote:
> > The only issue I have with this is that if a global section appears in a configuration file, the section will end up having its defaults applied twice. Is there a safe way to ensure that global sections do not have their defaults applied when such a section is encountered while parsing the config file?

I'll remove the init on encounter from process_category since it is now entirely redundant.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2866/#review9734
-----------------------------------------------------------


On Sept. 17, 2013, 7:27 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2866/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 7:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22318
>     https://issues.asterisk.org/jira/browse/ASTERISK-22318
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Ensure that when config objects are allocated, global objects are initialized properly.
> 
> 
> Diffs
> -----
> 
>   branches/11/main/config_options.c 399155 
> 
> Diff: https://reviewboard.asterisk.org/r/2866/diff/
> 
> 
> Testing
> -------
> 
> Tested config validity with no udptl.conf, blank udptl.conf, and configured udptl.conf.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130918/7391b8f8/attachment.htm>