[asterisk-dev] [Code Review] 2859: Make config framework able to reload module configs with multiple config files.

Mark Michelson reviewboard at asterisk.org
Tue Sep 17 15:25:22 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2859/#review9727
-----------------------------------------------------------

Ship it!


About 80% of the size of this diff (at least as it appears on Review Board) has nothing to do with the bug being fixed. Please try to keep reviews limited to the actual bug fix. If you want to clean up other areas, please either do so in a separate review, or just commit the cleanup changes separately.

- Mark Michelson


On Sept. 16, 2013, 9:29 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2859/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 9:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22009
>     https://issues.asterisk.org/jira/browse/ASTERISK-22009
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The config framework is supposed to be able to load configs that come from multiple config files.  The principle example is chan_sip's sip.conf and users.conf.  Unfortunately, it only does this correctly on initial load.  This patch causes the module's config to be reloaded entirely if any of the config files changes.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/config_options.c 399219 
> 
> Diff: https://reviewboard.asterisk.org/r/2859/diff/
> 
> 
> Testing
> -------
> 
> Compile and code inspection.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130917/b2947682/attachment.htm>


More information about the asterisk-dev mailing list