[asterisk-dev] [Code Review] 2845: Restore Dial, Queue, and FollowMe 'I' option support.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2845/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 6:21 p.m.)


Review request for Asterisk Developers.


Changes
-------

* Addressed mmichelson's comments.
* Made all callers of ast_bridge_impart() check the return value.  It is important.
* Removed some cleanup changes in test_cdr.c for a later patch.
* Did some cleanup in parking_tests.c.


Bugs: ASTERISK-22072
    https://issues.asterisk.org/jira/browse/ASTERISK-22072


Repository: Asterisk


Description
-------

The Dial, Queue, and FollowMe applications need to inhibit the bridging initial connected line exchange in order to support the 'I' option.

* Replaced the pass_reference flag on ast_bridge_join() with a flags parameter to pass other flags defined by enum ast_bridge_join_flags.

* Replaced the independent flag on ast_bridge_impart() with a flags parameter to pass other flags defined by enum ast_bridge_impart_flags.

* Since the Dial, Queue, and FollowMe applications are now the only callers of ast_bridge_call() and ast_bridge_call_with_flags(), changed the calling contract to require the initial COLP exchange to already have been done by the caller.

An independent, but associated change is:
* Reduce stack usage in ast_indicate_data() and add a dropping redundant connected line verbose message.


Diffs (updated)
-----

  /branches/12/apps/app_agent_pool.c 399094 
  /branches/12/apps/confbridge/conf_chan_announce.c 399094 
  /branches/12/channels/chan_sip.c 399094 
  /branches/12/include/asterisk/bridge.h 399094 
  /branches/12/include/asterisk/bridge_channel.h 399094 
  /branches/12/include/asterisk/features.h 399094 
  /branches/12/main/bridge.c 399094 
  /branches/12/main/bridge_basic.c 399094 
  /branches/12/main/bridge_channel.c 399094 
  /branches/12/main/channel.c 399094 
  /branches/12/main/core_local.c 399094 
  /branches/12/main/core_unreal.c 399094 
  /branches/12/main/features.c 399094 
  /branches/12/res/parking/parking_applications.c 399094 
  /branches/12/res/parking/parking_bridge_features.c 399094 
  /branches/12/res/parking/parking_tests.c 399094 
  /branches/12/res/res_pjsip_refer.c 399094 
  /branches/12/res/stasis/control.c 399094 
  /branches/12/tests/test_cdr.c 399094 
  /branches/12/tests/test_cel.c 399094 

Diff: https://reviewboard.asterisk.org/r/2845/diff/


Testing
-------

Tested Dial, Queue, and FollowMe with and without the 'I' option.  The connected line information was as expected.

In the process of testing the Queue I option, I came across a couple of assertions which I filed as ASTERISK-22506 and ASTERISK-22507.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/ba152510/attachment.htm>