[asterisk-dev] [Code Review] 2850: XML Config documentation for external_media_address in res_pjsip, transport and endpoint configurations

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2850/#review9701
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Sept. 13, 2013, 1:14 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2850/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 1:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22405
>     https://issues.asterisk.org/jira/browse/ASTERISK-22405
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Both endpoint and transport config objects have "external_media_address" options. The documentation doesn't currently clarify their behavior.
> 
> Mark Michelson described the behavior to me and I've taken his descriptions and used most of them for the help text.
> 
> * Modifying synopsis for both options
> * Adding description to both options
> * Changing name of "external_media_address" for Endpoint configuration to "media_address" in anticipation of the option name being changed. (As it is not really specific to external destinations)
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip.c 399030 
> 
> Diff: https://reviewboard.asterisk.org/r/2850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/bea6c246/attachment-0001.htm>