[asterisk-dev] [Code Review] 2825: Remote console: more output discrepancies

[Guenther Kelleter]

> On Sept. 12, 2013, 4:27 p.m., Guenther Kelleter wrote:
> > branches/11/main/logger.c, lines 1811-1839
> > <https://reviewboard.asterisk.org/r/2825/diff/4/?file=45801#file45801line1811>
> >
> >     You are only prepending magic and prefix to new lines of the format string but you also have to consider those inside the ap argument vector. That's why DumpChan() output is still incorrect.
> >     
> >     The unprefixed output string has to be created first and then the magic and prefix added to any new line of this string.

It's looking good now! I cannot reproduce the incorrect DumpChan() output from above anymore.


- Guenther


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2825/#review9670
-----------------------------------------------------------


On Sept. 12, 2013, 9:37 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2825/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 9:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22450
>     https://issues.asterisk.org/jira/browse/ASTERISK-22450
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This is a follow up to https://reviewboard.asterisk.org/r/2798/
> 
> The remote console continued to have issues with its output.  In this case CLI command output would either not show up (if verbose level = 0) or would contain verbose prefixes (if verbose level > 0) once log messages were sent to the remote console.  The fix now distinguishes between verbose log messages and cli command output sent to a remote console.
> 
> 
> Diffs
> -----
> 
>   branches/11/main/asterisk.c 398807 
>   branches/11/main/logger.c 398807 
> 
> Diff: https://reviewboard.asterisk.org/r/2825/diff/
> 
> 
> Testing
> -------
> 
> Duplicated issues.  Then ran scenarios again and observed that the issues were no longer occurring.  Also tried several other combinations of log levels and cli commands between consoles (local/remote).
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/3ec8ef6b/attachment-0001.htm>