[asterisk-dev] [Code Review] 2848: Confbridge: empty conference not being torn down

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2848/#review9698
-----------------------------------------------------------



branches/11/apps/confbridge/conf_state_multi_marked.c
<https://reviewboard.asterisk.org/r/2848/#comment18861>

    I think you need to test the same bits as the other if test:
    if (WAITMARKED && !MARKEDUSER)
    
    If there is more than one marked user in the conference the other marked user will not be kicked correctly.
    
    Do test to make sure I am correct.


- rmudgett


On Sept. 12, 2013, 3:49 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2848/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 3:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21859
>     https://issues.asterisk.org/jira/browse/ASTERISK-21859
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Confbridge would not properly tear down an empty conference bridge when all users were kicked via end_marked=yes and at least one user was also set to wait_marked.  This occurred because while end_marked users were being kicked and at least one was also set to wait_marked then the leave wait_marked handler would be called on that user, but there would be no waiting user (still considered active).  The waiting users would decrement and now be negative.  The conference would remain, but be put into an inactive state.  The solution was to move from the active list to the wait list, those users with wait_marked set right before kicking.  This allows both the active and wait users to decrement correctly and the confbridge to tear down properly.
> 
> A crashed also occurred when trying to list the specific conference from the CLI.  This happened because the conference specified was invalid.  Since the conference properly tears down now there is no way to reference it thus alleviating the crash as well.
> 
> 
> Diffs
> -----
> 
>   branches/11/apps/confbridge/conf_state_multi_marked.c 398808 
> 
> Diff: https://reviewboard.asterisk.org/r/2848/diff/
> 
> 
> Testing
> -------
> 
> Started by recreating the issue and then testing the fix against the scenario to make sure it worked.  Also ran a few other confbridge scenarios with various combinations of leaders and users that were marked, unmarked, and/or wait marked and made sure once the last participant left or was kicked the conference was fully removed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/d40e1f96/attachment-0001.htm>