[asterisk-dev] [Code Review] 2781: config_options: Drop missing config file ERROR statement to a WARNING

Matt Jordan reviewboard at asterisk.org
Thu Sep 12 19:57:14 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2781/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 12:57 a.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

One liner, but it is worth discussing.

Currently, if config_options doesn't detect a config file for a module, it emits an ERROR.

That seems a bit excessive, particularly for config files processed by the Asterisk core. It is not an error to be missing acl.conf - you just won't have ACLs. That feels like a WARNING at best to me.

Objections?


Diffs
-----

  /trunk/main/config_options.c 397306 

Diff: https://reviewboard.asterisk.org/r/2781/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/7fec73b1/attachment.htm>


More information about the asterisk-dev mailing list