[asterisk-dev] [Code Review] 2823: Documentation fix and improvements to XML configuration help res_pjsip_acl
Mark Michelson
reviewboard at asterisk.org
Thu Sep 12 18:02:17 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2823/#review9696
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On Sept. 12, 2013, 10:47 p.m., rnewton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2823/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 10:47 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22458
> https://issues.asterisk.org/jira/browse/ASTERISK-22458
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> One bug fix. The synopsis for "type" was wrong.
>
> When Mark and I were looking at some ACL issue we noted that there should be some improvements to the documentation.
>
> Notably:
>
> * changing the usage of "IP-domains" to "IP addresses"
> * clarifying the usage for the options, by adding a relevant description for each
> * modified other areas of the XML help for clarity, such as the module description and a few synopsis changes here and there. See the patch.
>
>
> Diffs
> -----
>
> /branches/12/res/res_pjsip_acl.c 399015
>
> Diff: https://reviewboard.asterisk.org/r/2823/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> rnewton
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/7fc2a621/attachment.htm>
More information about the asterisk-dev
mailing list