[asterisk-dev] [Code Review] 2835: res_pjsip_notify: Add documentation

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2835/#review9692
-----------------------------------------------------------



./branches/12/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2835/#comment18855>

    Hm, for the sake of consistency and not creating collisions with chan_sip, we should probably read configuration from pjsip_notify.conf instead of sip_notify.conf



./branches/12/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2835/#comment18857>

    Really pedantic, but I'd remove the word "value" from this sentence.



./branches/12/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2835/#comment18859>

    Subject-verb agreement issue here. "A key value...are appended"



./branches/12/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2835/#comment18856>

    I would add the list of reserved headers that cannot be specified:
    
    Call-ID
    Contact
    CSeq
    To
    From
    Record-Route
    Route
    Via
    
    


- Mark Michelson


On Sept. 7, 2013, 2:55 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2835/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 2:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> We forgot to add the documentation for res_pjsip_notify. Whoops.
> 
> 
> Diffs
> -----
> 
>   ./branches/12/res/res_pjsip_notify.c 398627 
> 
> Diff: https://reviewboard.asterisk.org/r/2835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/5a4dd547/attachment-0001.htm>