[asterisk-dev] [Code Review] 2833: res_pjsip_messaging: Register message technology as pjsip

[Kevin Harwell]

> On Sept. 12, 2013, 7:48 p.m., opticron wrote:
> > branches/12/res/res_pjsip_messaging.c, lines 260-262
> > <https://reviewboard.asterisk.org/r/2833/diff/1/?file=45700#file45700line260>
> >
> >     This does not handle the case where 'pjsip' occurs somewhere beyond the scheme in the URI.

I may be misunderstanding, but don't we only care about the scheme part?  If someone places 'pjsip' some other place in the uri that's fine.


> On Sept. 12, 2013, 7:48 p.m., opticron wrote:
> > branches/12/res/res_pjsip_messaging.c, lines 331-332
> > <https://reviewboard.asterisk.org/r/2833/diff/1/?file=45700#file45700line331>
> >
> >     This function will only return NULL on allocation failure in which case the message could end up missing important fields and still be sent.

I think this is okay since it tries to locate an endpoint based upon the "to" information.  If it's NULL or otherwise not formed correctly then the endpoint won't be found and the message won't be sent.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2833/#review9686
-----------------------------------------------------------


On Sept. 6, 2013, 11:03 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2833/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 11:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22445
>     https://issues.asterisk.org/jira/browse/ASTERISK-22445
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> pjsip's message technology was being registered as 'sip', which was causing it to not load due it conflicting with chan_sip's registered 'sip' technology for messaging.  It now registers as 'pjsip'.  However, due to this change the "to" field for outgoing pjsip messages need to be prefixed with 'pjsip:' instead of 'sip:'.  Incoming messages to res_pjsip_messaging will automatically have their "to" fields altered in order to accommodate the change.  Outgoing messages also handle changing it back to 'sip' before being sent so the pjsip library will properly handle it.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_messaging.c 398225 
> 
> Diff: https://reviewboard.asterisk.org/r/2833/diff/
> 
> 
> Testing
> -------
> 
> Updated the pjsip messaging testsuite tests and made sure passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/18fd16bb/attachment.htm>