[asterisk-dev] [Code Review] 2829: Testsuite: Tests for outbound PJSIP authentication

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2829/#review9685
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/2829/#comment18847>

    This is not necessary for the test to execute properly.



/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast2/pjsip.conf
<https://reviewboard.asterisk.org/r/2829/#comment18846>

    Idem.


- opticron


On Sept. 6, 2013, 1:42 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2829/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 1:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22386 and ASTERISK-22471
>     https://issues.asterisk.org/jira/browse/ASTERISK-22386
>     https://issues.asterisk.org/jira/browse/ASTERISK-22471
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> On ASTERISK-22471, George Joseph created a patch that eases the burden of outbound authentication. If no realm is specified in an auth section, then we will simply mirror the realm presented in the 401/407 response that we receive.
> 
> Since this patch is a candidate for Asterisk 12, it is required to have test coverage. This set of tests exercises outbound authentication. The test starts up two Asterisk instances, uut and bob. uut places four outbound calls to bob. Bob challenges each of the four calls the exact same way; however, the authentication is configured four different ways on uut. uut is expected to be able to respond to each of the four challenges correctly.
> 
> The four methods of authentication configuration are:
> 1. Userpass authentication, explicit realm present.
> 2. Userpass authentication, no realm specified.
> 3. MD5 authentication, explicit realm present.
> 4. MD5 authentictaion, no realm specified.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/tests.yaml 4126 
> 
> Diff: https://reviewboard.asterisk.org/r/2829/diff/
> 
> 
> Testing
> -------
> 
> The tests pass with the patch from ASTERISK-22471 applied. Without the patch, cases 2 and 4 are unable to authenticate properly.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/0018b7b9/attachment.htm>