[asterisk-dev] [Code Review] 2770: TestSuite: ARI Bridge Tests

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2770/#review9684
-----------------------------------------------------------



/asterisk/trunk/tests/rest_api/bridges/hangup/bridge_hangup.py
<https://reviewboard.asterisk.org/r/2770/#comment18842>

    Is there any reason not to just define these two members in global scope since the majority of the class is now gone? Idem for happy and move tests.



/asterisk/trunk/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18845>

    This import is unnecessary.



/asterisk/trunk/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18844>

    Idem.



/asterisk/trunk/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18843>

    Idem.


- opticron


On Sept. 12, 2013, 11:56 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2770/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 11:56 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22036
>     https://issues.asterisk.org/jira/browse/ASTERISK-22036
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> TestSuite tests that test the expected behavior for adding/removing
> channel to/from bridges using ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 4167 
>   /asterisk/trunk/lib/python/asterisk/TestConfig.py 4167 
>   /asterisk/trunk/lib/python/asterisk/ari.py 4167 
>   /asterisk/trunk/tests/rest_api/bridges/hangup/bridge_hangup.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/hangup/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/hangup/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/happy/bridge_happy.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/happy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/happy/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/move/bridge_move.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/move/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/move/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/unhappy/bridge_unhappy.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/unhappy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/unhappy/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/continue/test-config.yaml 4167 
>   /asterisk/trunk/tests/rest_api/tests.yaml 4167 
> 
> Diff: https://reviewboard.asterisk.org/r/2770/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> https://reviewboard.asterisk.org/r/2769/
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/785283ce/attachment-0001.htm>