[asterisk-dev] [Code Review] 2844: Fix several crashes in MeetMeAdmin

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2844/#review9683
-----------------------------------------------------------

Ship it!



branches/1.8/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2844/#comment18841>

    While I won't try to enforce its use here, I will point out that RAII_VAR exists in 1.8 and could be used here if desired.


- Mark Michelson


On Sept. 11, 2013, 5:42 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2844/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 5:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21907
>     https://issues.asterisk.org/jira/browse/ASTERISK-21907
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change ensures that MeetMeAdmin commands requiring a user actually get a user and fixes another issue where an extra dereference could occur for a last-entered user being ejected if a user identifier was also provided.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_meetme.c 398803 
> 
> Diff: https://reviewboard.asterisk.org/r/2844/diff/
> 
> 
> Testing
> -------
> 
> Manual calls to MeetMeAdmin with several of the offending options.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/55dfdfd2/attachment.htm>