[asterisk-dev] [Code Review] 2841: chan_sip: Don't allow T38 error correction offered by remote peer when error correction mode is explicitly set to 'none'

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2841/#review9677
-----------------------------------------------------------



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2841/#comment18834>

    configured_ec_scheme is actually what it is



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2841/#comment18837>

    This behavior change needs to be documented, and it's sort of half new behavior and half old.
    
    If I configure none then no ec will be accepted.
    If I configure redundancy then redundancy OR fec will be accepted.
    If I configure fec then fec OR redundancy will be accepted.
    
    The actual behavior of the option needs to be more completely specified.


- Joshua Colp


On Sept. 10, 2013, 10:10 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2841/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 10:10 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp and Mark Michelson.
> 
> 
> Bugs: ASTERISK-21150
>     https://issues.asterisk.org/jira/browse/ASTERISK-21150
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> By default, if t38 is enabled then the error correction mode will be set to FEC. Optionally, if t38pt_udptl is set to 'yes,none', then it will be set to use no error correction. However, currently if Asterisk receives an invite with error correction in it for a peer with error correction disabled, it will include the offered error correction in outgoing invites.
> 
> This patch was written and tested by Nitesh Bansal. It adds some error correction mode checking while processing the SDP and if an image header is detected in SDP for a peer that hasn't enabled T38 yet with an error correction scheme of none, then the error correction scheme will explicitly be set to none for the SIP private's UDPTL session.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 398636 
> 
> Diff: https://reviewboard.asterisk.org/r/2841/diff/
> 
> 
> Testing
> -------
> 
> Made sure the patch doesn't negatively impact fax tests (when applied to Asterisk 11)
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/2c12f02a/attachment.htm>