[asterisk-dev] [Code Review] 2817: testsuite: Update tests/bridge/disconnect to accomodate Asterisk 12 CEL changes

opticron reviewboard at asterisk.org
Thu Sep 12 08:35:57 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2817/#review9666
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/bridge/disconnect/test-config.yaml
<https://reviewboard.asterisk.org/r/2817/#comment18823>

    Matching requirement IDs across cel sections is pretty neat. I didn't realize the new CEL event validator could do that.


- opticron


On Sept. 3, 2013, 1:55 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2817/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 1:55 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22325
>     https://issues.asterisk.org/jira/browse/ASTERISK-22325
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Uses python library changes from https://reviewboard.asterisk.org/r/2799/ to add AMI functionality for IDs/before and after ID event matching
> 
> Some CEL types are replaced in 12 and the order of events is generally more chaotic as well, so this test uses conditional matching and relative ordering when ran against Asterisk 12 now.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/disconnect/test-config.yaml 4102 
> 
> Diff: https://reviewboard.asterisk.org/r/2817/diff/
> 
> 
> Testing
> -------
> 
> Ran test several times against 12 to make sure it could satisfy passing conditions with every CEL output it encountered while also making sure the output was sane for each of the tested cases by hand.
> 
> Ran test against 11 to make sure I didn't accidentally break it.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/e09ef5eb/attachment.htm>


More information about the asterisk-dev mailing list