[asterisk-dev] [Code Review] 2770: TestSuite: ARI Bridge Tests

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2770/#review9665
-----------------------------------------------------------



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/bridge_hangup.py
<https://reviewboard.asterisk.org/r/2770/#comment18814>

    This should contain an __init__ function that sets up self.channel_id and self.bridge_id.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/test-config.yaml
<https://reviewboard.asterisk.org/r/2770/#comment18813>

    Is the blank config section necessary? The code in the test object looks like it should handle the lack of a config section properly.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/bridge_happy.py
<https://reviewboard.asterisk.org/r/2770/#comment18815>

    This should contain an __init__ function that sets up self.channel_id and self.bridge_id.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/test-config.yaml
<https://reviewboard.asterisk.org/r/2770/#comment18816>

    Empty config section.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/bridge_move.py
<https://reviewboard.asterisk.org/r/2770/#comment18817>

    This should contain an __init__ function that sets up self.channel_id, self.bridge1_id, and self.bridge2_id.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/test-config.yaml
<https://reviewboard.asterisk.org/r/2770/#comment18818>

    Empty config section.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18819>

    This should also setup self.passing.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18820>

    Invert the test to simplify and remove a block.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18821>

    Remove from a nonexistent bridge.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/test-config.yaml
<https://reviewboard.asterisk.org/r/2770/#comment18822>

    s/then/them/


- opticron


On Aug. 27, 2013, 2:32 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2770/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 2:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22036
>     https://issues.asterisk.org/jira/browse/ASTERISK-22036
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> TestSuite tests that test the expected behavior for adding/removing
> channel to/from bridges using ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/tests.yaml 4089 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/tests.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/bridge_move.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/TestCase.py 4089 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/TestConfig.py 4089 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/ari.py 4089 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/bridge_hangup.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/bridge_happy.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2770/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> https://reviewboard.asterisk.org/r/2769/
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/d0a9b258/attachment-0001.htm>