[asterisk-dev] [Code Review] 2815: testsuite: bridge/parkcall_blindxfer test update for res_parking module and related changes.

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2815/#review9660
-----------------------------------------------------------

Ship it!


Looks okay to me.

- David Lee


On Sept. 2, 2013, 5:07 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2815/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 5:07 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22328
>     https://issues.asterisk.org/jira/browse/ASTERISK-22328
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test was originally written by John Bigelow. I've updated it to handle the test events it expects within their own functions rather than by using event parameters to address all of the events.
> 
> In other regards, the problems here were similar to other review tests.  There is a difference in the expectations of events between 11 and 12.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/Hangup.py 4081 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/configs/ast1/extensions.conf 4081 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/configs/ast1/res_parking.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/test-config.yaml 4081 
>   /asterisk/trunk/tests/bridge/tests.yaml 4081 
> 
> Diff: https://reviewboard.asterisk.org/r/2815/diff/
> 
> 
> Testing
> -------
> 
> Tested in Asterisk 11 and 12 to make sure they still passed and processed everything expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130911/7758bca5/attachment.htm>