[asterisk-dev] [Code Review] 2842: PJSIP: Create better Contact header for responses when creating dialogs.

[jbigelow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2842/#review9657
-----------------------------------------------------------


It appears to fix a couple pjsip tests in the testsuite. More would most likely pass but are affected by additional issues. I'll leave it to others to review the actual code.

- jbigelow


On Sept. 10, 2013, 12:56 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2842/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers, jbigelow and Joshua Colp.
> 
> 
> Bugs: AST-1207
>     https://issues.asterisk.org/jira/browse/AST-1207
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> John Bigelow discovered during testing calls between two Asterisk boxes that ACKs were being sent to the wrong port. As it turned out, the ACKs were dutifully being sent to the destination specified in the Contact header of the 200 OK. The issue is that the UAS Asterisk instance was populating the Contact header with bad information. This was because we were using PJSIP's default behavior, which is to populate the Contact header with the information in the To header of the incoming INVITE, which contained no port.
> 
> This patch changes the contact header used at UAS-side dialog creation time to be based on the transport on which the incoming request was received. The API call includes the endpoint, which for now is unused other than in a warning message if dialog creation fails. This is thinking ahead in case we want to use a configured transport on the endpoint as a means of creating the contact header instead.
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/res_pjsip.h 398367 
>   /branches/12/res/res_pjsip.c 398367 
>   /branches/12/res/res_pjsip.exports.in 398367 
>   /branches/12/res/res_pjsip_pubsub.c 398367 
>   /branches/12/res/res_pjsip_session.c 398367 
> 
> Diff: https://reviewboard.asterisk.org/r/2842/diff/
> 
> 
> Testing
> -------
> 
> Tested incoming calls from phones and SIPp. Tried setting Asterisk to use a non-standard port for SIP, and ensured that the Contact header from Asterisk included the port.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130911/f2aa542f/attachment.htm>