[asterisk-dev] [Code Review] 2840: Restore usefulness of the CEL Peer field

[opticron]

> On Sept. 10, 2013, 2:17 p.m., Mark Michelson wrote:
> > /branches/12/tests/test_cel.c, lines 292-357
> > <https://reviewboard.asterisk.org/r/2840/diff/3/?file=45789#file45789line292>
> >
> >     This doesn't really test CEL, since it's not testing the peer string generation that's actually in main/cel.c.

This only generates the peer string for the expected events on the unit test side. The incoming (real) events still have peer strings generated by the CEL engine.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2840/#review9650
-----------------------------------------------------------


On Sept. 10, 2013, 10:40 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2840/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 10:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22393
>     https://issues.asterisk.org/jira/browse/ASTERISK-22393
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change makes the CEL peer field useful again for BRIDGE_ENTER and BRIDGE_EXIT events and fills the field with a comma-separated list of all channels in the bridge other than the channel that is entering or exiting.
> 
> 
> Diffs
> -----
> 
>   /branches/12/tests/test_cel.c 398744 
>   /branches/12/main/cel.c 398744 
>   /branches/12/include/asterisk/cel.h 398744 
> 
> Diff: https://reviewboard.asterisk.org/r/2840/diff/
> 
> 
> Testing
> -------
> 
> The CEL unit tests pass once they were modified to take peer field matching into account.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130911/844b7660/attachment-0001.htm>