[asterisk-dev] [Code Review] 2831: pjsip: reinvite for connected line updates occurs when it should not

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2831/#review9635
-----------------------------------------------------------



branches/12/channels/chan_pjsip.c
<https://reviewboard.asterisk.org/r/2831/#comment18792>

    I think the && on line 2 of this if statement should be || instead.
    
    trust_outbound is intended to let us know that we can send restricted name and number information to this endpoint. With && here we require that trust_outbound is true AND that the name and number are allowed. If trust_outbound is set, we don't care if the name or number are restricted. It's only if trust_outbound is not set that we actually might not send restricted information.


- Mark Michelson


On Sept. 6, 2013, 10:41 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2831/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 10:41 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Bugs: AST-1212
>     https://issues.asterisk.org/jira/browse/AST-1212
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Connected line updates are now only sent out if an actual update needs to occur.  This happens under the following conditions:
> 
> 1. The endpoint we are sending to is trusted.
> 2. Either a P-Asserted-Identity or Remote Party-ID header needs to be added/sent.
> 3. The connected id's number and name are valid.
> 
> Also added an SDP when an update is sent out.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_caller_id.c 398520 
>   branches/12/channels/chan_pjsip.c 398520 
> 
> Diff: https://reviewboard.asterisk.org/r/2831/diff/
> 
> 
> Testing
> -------
> 
> Saw this issue occur while running a messaging testsuite test causing it to fail.  Ran the test again after the fix was put in and it no longer happens.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130909/8cfea82b/attachment.htm>