[asterisk-dev] [Code Review] 2826: Debug threads: avoid double-initialization of lock tracking

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2826/
-----------------------------------------------------------

(Updated Sept. 5, 2013, 12:57 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Improved calloc() call.


Bugs: ASTERISK-19463
    https://issues.asterisk.org/jira/browse/ASTERISK-19463


Repository: Asterisk


Description
-------

This patch corrects a consistency issue with debug threads that I
noticed while fixing ASTERISK-22455.

The initialization of a mutex's lock tracking structure was not
protected in a critical section. This is fine for any mutex that is
explicitly initialized, but a static mutex may have its lock tracking
double-initialized if multiple threads attempt the first lock
simultaneously.

This patch creates a global mutex to properly serialize the
initialization of the lock tracking structure for a mutex. It also
changes lock.c to properly handle allocation failures of the lock
tracking structure.


Diffs (updated)
-----

  /branches/1.8/include/asterisk/lock.h 398378 
  /branches/1.8/main/lock.c 398378 

Diff: https://reviewboard.asterisk.org/r/2826/diff/


Testing
-------

I propose we setup Bamboo to run the TestSuite with DEBUG_THREADS
enabled on this branch nightly for a few weeks.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/5ebd07d8/attachment-0001.htm>