[asterisk-dev] [Code Review] 2816: testsuite: bridge/parkcall_timeout tests - update for res_parking module and related changes.

[jrose]

> On Sept. 5, 2013, 3:49 p.m., Mark Michelson wrote:
> > The changes are fine here.
> > 
> > A recommendation though: when making changes like this, try to isolate your changes just to what is needed to get the test running. The PEP-8 changes to the rest of the file are nice, but they make reviewing more difficult. The PEP-8 changes can be made later in a separate commit.

Well, on the bright side, Diff r1 is still viewable and included everything but the PEP-8 changes, but I'll go ahead and take your advice on future reviews.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2816/#review9598
-----------------------------------------------------------


On Sept. 4, 2013, 2:14 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2816/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 2:14 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22328
>     https://issues.asterisk.org/jira/browse/ASTERISK-22328
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Update the parkcall_timeout tests (comebacktoorigin_yes and comebacktoorigin_no) to address differences in how things work between 12 and previous version. Again, events and CDR expectations mostly, but it turned out Asterisk 11 was really failing the parkcall_timeout/comebacktoorigin_yes test and wasn't being reported as such. 11 doesn't set certain channel variables (PARKINGLOT and PARKINGSLOT/PARKINGSPACE) when comebacktoorigin = yes which are set when it is set to no. Asterisk 12 applies these channel variables regardless of that condition (this is a change that was discussed and we decided it was a positive and unobtrusive one).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/Executioner.py 4081 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/configs/ast1/res_parking.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml 4081 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/Executioner.py 4081 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/res_parking.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml 4081 
>   /asterisk/trunk/tests/bridge/tests.yaml 4081 
> 
> Diff: https://reviewboard.asterisk.org/r/2816/diff/
> 
> 
> Testing
> -------
> 
> Tested both tests for Asterisk 11 and 12 to make sure they pass.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/9cc0a9bc/attachment.htm>