[asterisk-dev] [Code Review] 2825: Remote console: more output discrepancies

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2825/#review9594
-----------------------------------------------------------


It's not clear why adding a magic value for cli output is the answer here.


branches/11/main/asterisk.c
<https://reviewboard.asterisk.org/r/2825/#comment18774>

    I don't see where you're using this define.



branches/11/main/asterisk.c
<https://reviewboard.asterisk.org/r/2825/#comment18775>

    So level will be 127, when you're outputting via the cli (non-verbose), correct?  Is that really what you intended?



branches/11/main/logger.c
<https://reviewboard.asterisk.org/r/2825/#comment18773>

    I feel like the comparison ought to be "level >= 9 ? -10 ..." because that's the maximum level allowed.  Yes, it doesn't actually change anything, but the implication is more clear.


- Tilghman Lesher


On Sept. 4, 2013, 10:29 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2825/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 10:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22450
>     https://issues.asterisk.org/jira/browse/ASTERISK-22450
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This is a follow up to https://reviewboard.asterisk.org/r/2798/
> 
> The remote console continued to have issues with its output.  In this case CLI command output would either not show up (if verbose level = 0) or would contain verbose prefixes (if verbose level > 0) once log messages were sent to the remote console.  The fix now distinguishes between verbose log messages and cli command output sent to a remote console.
> 
> 
> Diffs
> -----
> 
>   branches/11/include/asterisk/cli.h 398227 
>   branches/11/main/asterisk.c 398227 
>   branches/11/main/cli.c 398227 
>   branches/11/main/logger.c 398227 
> 
> Diff: https://reviewboard.asterisk.org/r/2825/diff/
> 
> 
> Testing
> -------
> 
> Duplicated issues.  Then ran scenarios again and observed that the issues were no longer occurring.  Also tried several other combinations of log levels and cli commands between consoles (local/remote).
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/b348c384/attachment-0001.htm>