[asterisk-dev] [Code Review] 2976: chan_sip: notify dialog info ignores presentation indicator in callerid

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2976/#review10081
-----------------------------------------------------------


this review is much larger than it needs to be due to a lot of spacing changes made throughout chan_sip.c. Please try to keep reviews limited to the scope of the issue being fixed. If you want to fix spacing problems in chan_sip.c, that can be done as a separate review or just committed as its own changeset.


branches/11/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2976/#comment19358>

    I think the cid_num and name need the same logic applied to it as the connected line number and name.



branches/11/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2976/#comment19359>

    When the number is to remain anonymous, you should obscure the domain portion as well. RFC 3261 gives the suggestion of using "anonymous.invalid" for this.


- Mark Michelson


On Oct. 30, 2013, 2:07 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2976/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 2:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1175
>     https://issues.asterisk.org/jira/browse/AST-1175
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The presentation indicator in a callerid (e.g. set by dialplan function Set(CALLERID(name-pres)= ...)) is not checked when SIP Dialog Info Notifies are generated during extension monitoring.  Added a check to make sure the name and/or number presentations on the callee (remote identity) are set to allow.  If they are restricted then "anonymous" is used instead. 
> 
> 
> Diffs
> -----
> 
>   branches/11/channels/chan_sip.c 402221 
> 
> Diff: https://reviewboard.asterisk.org/r/2976/diff/
> 
> 
> Testing
> -------
> 
> Using SIPp subscribed to dialog-info for a phone then made a call from another phone to the subscribed phone and observed that the remote identity was being replaced when either the name and/or number presentations were set to restricted.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/b086c14f/attachment.html>