[asterisk-dev] [Code Review] 2969: config: Allow ConfBridge DTMF menus to have '#' as the first digit.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2969/
-----------------------------------------------------------

(Updated Oct. 31, 2013, 8:48 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review findings from Kinsey and Mark.


Bugs: ASTERISK-22478
    https://issues.asterisk.org/jira/browse/ASTERISK-22478


Repository: Asterisk


Description
-------

ConfBridge allows custom DTMF menus to be created in the confbridge.conf file by assigning a DTMF key sequence to a sequence of actions as follows:
DTMF-sequence = action,list
Unfortunately, the normal config file processing code interprets an initial '#' character as starting a directive such as #include.

* Add the ability to escape the first non-blank character in a config line so the '#' character can be used without triggering the directive processing code.


Diffs (updated)
-----

  /branches/11/main/config.c 402326 

Diff: https://reviewboard.asterisk.org/r/2969/diff/


Testing
-------

Escaping the first non-blank character in the config line now allows ConfBridge DTMF menus to start a DTMF sequence with the '#' character.
\#1=action

Tested other special characters to see if they no longer are interpreted specially:
\+= value  Is interpreted as name '+' assigned to value.
+= value   Is rejected as not having a name.
\== value  Is interpreted as name '=' assigned to value.
== value   Is rejected as not having a name.
\          Is rejected as an invalid escape.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/fdbb6239/attachment.html>