[asterisk-dev] [Code Review] 2973: Add equivalent AMI actions for the bridge CLI commands.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2973/#review10077
-----------------------------------------------------------

Ship it!


Like Richard's review, my critiques are all on documentation. The code itself is good though.


/branches/12/include/asterisk/bridge.h
<https://reviewboard.asterisk.org/r/2973/#comment19353>

    For the return non-NULL case, change the word "pointer" to "reference" so it is more clear that the caller is responsible for decrementing the refcount of the bridge when completed.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19354>

    s/status/statuses/
    
    subject-verb agreement, yo!



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19355>

    s/inforamtion/information/


- Mark Michelson


On Oct. 31, 2013, 7:17 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2973/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 7:17 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22356
>     https://issues.asterisk.org/jira/browse/ASTERISK-22356
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds the following AMI events mirroring their CLI counterparts:
> 
> BridgeDestroy
> BridgeKick
> BridgeTechnologyList
> BridgeTechnologySuspend
> BridgeTechnologyUnsuspend
> 
> In the case of BridgeKick, to simplify the coding both a BridgeUniqueid and a Channel name must be provided to kick a channel.
> 
> The Technology calls are implemented in bridge.c due to the technology link list being located there.
> 
> Also in bridge.c, a new function ast_bridge_find_by_id() is added to expose the bridges ao2 container in a convenient fashion.
> 
> Tests for these AMI commands are here: https://reviewboard.asterisk.org/r/2975/
>  
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/manager_bridges.c 402126 
>   /branches/12/main/bridge.c 402126 
>   /branches/12/include/asterisk/bridge.h 402126 
> 
> Diff: https://reviewboard.asterisk.org/r/2973/diff/
> 
> 
> Testing
> -------
> 
> All tests written passed to insure basic functionality.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/7902305d/attachment-0001.html>