[asterisk-dev] [Code Review] 2973: Add equivalent AMI actions for the bridge CLI commands.

Scott Griepentrog reviewboard at asterisk.org
Thu Oct 31 14:17:22 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2973/
-----------------------------------------------------------

(Updated Oct. 31, 2013, 2:17 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Changed the BridgeKick to just kick a channel from a bridge, since kicking the entire bridge duplicates BridgeDestroy.

Bridgekick now requires channel, bridgeid is optional and can be used to prevent kicking the channel out of another bridge that stole it.


Bugs: ASTERISK-22356
    https://issues.asterisk.org/jira/browse/ASTERISK-22356


Repository: Asterisk


Description
-------

Adds the following AMI events mirroring their CLI counterparts:

BridgeDestroy
BridgeKick
BridgeTechnologyList
BridgeTechnologySuspend
BridgeTechnologyUnsuspend

In the case of BridgeKick, to simplify the coding both a BridgeUniqueid and a Channel name must be provided to kick a channel.

The Technology calls are implemented in bridge.c due to the technology link list being located there.

Also in bridge.c, a new function ast_bridge_find_by_id() is added to expose the bridges ao2 container in a convenient fashion.

Tests for these AMI commands are here: https://reviewboard.asterisk.org/r/2975/
 


Diffs (updated)
-----

  /branches/12/main/manager_bridges.c 402126 
  /branches/12/main/bridge.c 402126 
  /branches/12/include/asterisk/bridge.h 402126 

Diff: https://reviewboard.asterisk.org/r/2973/diff/


Testing
-------

All tests written passed to insure basic functionality.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/10142096/attachment.html>


More information about the asterisk-dev mailing list